cccs-eric commented on code in PR #886:
URL: https://github.com/apache/iceberg-python/pull/886#discussion_r1663354850
##########
pyiceberg/catalog/sql.py:
##########
@@ -110,8 +110,28 @@ def __init__(self, name: str, **properties: str):
if not (uri_prop := self.properties.get("uri")):
raise NoSuchPropertyException("SQL connection URI is required")
- echo = bool(self.properties.get("echo", False))
- self.engine = create_engine(uri_prop, echo=echo)
+
+ echo: Union[str, bool]
+ echo_str = str(self.properties.get("echo", "false")).lower()
Review Comment:
Seems fair
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
