Fokko commented on PR #787: URL: https://github.com/apache/iceberg-python/pull/787#issuecomment-2159087897
Being able to configure (and also disable) the cachine would be a very nice touch Op ma 10 jun 2024 om 09:52 schreef Chinmay Bhat ***@***.***> > ***@***.**** commented on this pull request. > ------------------------------ > > In pyiceberg/table/snapshots.py > <https://github.com/apache/iceberg-python/pull/787#discussion_r1632758206> > : > > > @@ -228,6 +229,13 @@ def __eq__(self, other: Any) -> bool: > ) > > > ***@***.***_cache > > As the default is 128 > <https://docs.python.org/3/library/functools.html#functools.lru_cache>, I > don't think we need to explicitly define maxsize=128. > > Also, _manifests() is not a public API, so we would *probably* not set > the cache size through user config via pyiceberg.yaml. Is there a use-case > where the user would want to set the cache size? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg-python/pull/787#discussion_r1632758206>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAIU5KBBXVDMDRY62QQEY2LZGVLMNAVCNFSM6AAAAABIUZG46GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBWHEZTSOJSGQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
