chinmay-bhat commented on code in PR #787:
URL: https://github.com/apache/iceberg-python/pull/787#discussion_r1632758206
##########
pyiceberg/table/snapshots.py:
##########
@@ -228,6 +229,13 @@ def __eq__(self, other: Any) -> bool:
)
+@lru_cache
Review Comment:
As [the default is
128](https://docs.python.org/3/library/functools.html#functools.lru_cache), I
don't think we need to explicitly define `maxsize=128`.
Also, `_manifests()` is not a public API, so we would *probably* not set the
cache size through user config via pyiceberg.yaml. Is there a use-case where
the user would want to set the cache size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
