MehulBatra commented on code in PR #787:
URL: https://github.com/apache/iceberg-python/pull/787#discussion_r1632704500
##########
pyiceberg/table/snapshots.py:
##########
@@ -228,6 +229,13 @@ def __eq__(self, other: Any) -> bool:
)
+@lru_cache
Review Comment:
what are your thoughts on this, wouldn't be clearer if we could explicitly
pass the max size for the lru_cache annotation, to store max entries rather
than going default.
`@lru_cache(maxsize=128)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
