MehulBatra commented on PR #787:
URL: https://github.com/apache/iceberg-python/pull/787#issuecomment-2157521431
@chinmay-bhat @Fokko Sorry for the last-minute feedback, but wouldn't it be
better if we explicitly pass
(maxsize=128) for the lru_cache annotation, When a new call comes in, the
decorator’s implementation will evict the least recently used of the existing
128 entries to make a place for the new item. that way it would make it clearer
for the end user and increase the code visibility, in the near future we can
also take that as a user config via pyiceberg.yaml
```
@lru_cache(maxsize=128)
def _manifests(io: FileIO, manifest_list: str) -> List[ManifestFile]:
"""Return the manifests from the manifest list."""
file = io.new_input(manifest_list)
return list(read_manifest_list(file))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
