chinmay-bhat commented on PR #728: URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2124649841
Hi @HonahX , I've updated the PR based on your suggestions. I've made `set_ref_snapshot()` protected and created an inner class that takes care of snapshot management operations. In this PR, the operations include `create_tag` and `create_branch`. While testing, I realised that we(PyIceberg) only support the main branch, ie. while using `create_tag` or `create_branch`, if the branch/tag is "main", the snapshot_log and current_snapshot_id are updated, otherwise they don't reflect any changes. I'm assuming this is because we always display the main branch snapshot_log. I know the create_tag functions as expected because the metadata.refs[<branch_not_main>] show the expected snapshot after running create_tag. The test function is basicaly doing the above check to verify if it works. Am I missing something here, or do we need to create a PR to get the snapshot_log, current_snapshot and other details for every branch/tag? That said, since this PR holds the `ManageSnapshots` grouping which other PRs depend on, I would like to focus on getting this and the other PRs merged before exploring the branch/tag history problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
