syun64 commented on code in PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1597761797
##########
pyiceberg/table/__init__.py:
##########
@@ -340,6 +340,34 @@ def set_properties(self, properties: Properties =
EMPTY_DICT, **kwargs: Any) ->
updates = properties or kwargs
return self._apply((SetPropertiesUpdate(updates=updates),))
+ def set_ref_snapshot(
+ self,
+ snapshot_id: int,
+ parent_snapshot_id: Optional[int],
+ ref_name: str,
+ type: str,
+ max_age_ref_ms: Optional[int] = None,
+ max_snapshot_age_ms: Optional[int] = None,
+ min_snapshots_to_keep: Optional[int] = None,
+ ) -> Transaction:
+ """Update a ref to a snapshot.
+
+ Returns:
+ The transaction with the set-snapshot-ref staged
+ """
+ updates = SetSnapshotRefUpdate(
+ snapshot_id=snapshot_id,
+ parent_snapshot_id=parent_snapshot_id,
+ ref_name=ref_name,
+ type=type,
+ max_age_ref_ms=max_age_ref_ms,
+ max_snapshot_age_ms=max_snapshot_age_ms,
+ min_snapshots_to_keep=min_snapshots_to_keep,
+ )
+
+ requirements = AssertRefSnapshotId(snapshot_id=parent_snapshot_id,
ref="main")
Review Comment:
Could we add
[AssertTableUUID](https://github.com/apache/iceberg-python/blob/main/pyiceberg/table/__init__.py#L1010)
table requirement as well?
##########
pyiceberg/table/__init__.py:
##########
@@ -340,6 +340,34 @@ def set_properties(self, properties: Properties =
EMPTY_DICT, **kwargs: Any) ->
updates = properties or kwargs
return self._apply((SetPropertiesUpdate(updates=updates),))
+ def set_ref_snapshot(
+ self,
+ snapshot_id: int,
+ parent_snapshot_id: Optional[int],
+ ref_name: str,
+ type: str,
+ max_age_ref_ms: Optional[int] = None,
+ max_snapshot_age_ms: Optional[int] = None,
+ min_snapshots_to_keep: Optional[int] = None,
+ ) -> Transaction:
+ """Update a ref to a snapshot.
+
+ Returns:
+ The transaction with the set-snapshot-ref staged
+ """
+ updates = SetSnapshotRefUpdate(
+ snapshot_id=snapshot_id,
+ parent_snapshot_id=parent_snapshot_id,
+ ref_name=ref_name,
Review Comment:
I don't think we are expecting `parent_snapshot_id` in
[SetSnapshotRefUpdate](https://github.com/apache/iceberg-python/blob/main/pyiceberg/table/__init__.py#L618-L625)
```suggestion
snapshot_id=snapshot_id,
ref_name=ref_name,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
