HonahX commented on code in PR #728:
URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1621834384
##########
tests/table/test_init.py:
##########
@@ -652,6 +652,58 @@ def test_update_metadata_add_snapshot(table_v2: Table) ->
None:
assert new_metadata.last_updated_ms == new_snapshot.timestamp_ms
+def test_update_metadata_create_tag(table_v2: Table) -> None:
+ update =
table_v2.manage_snapshots().create_tag(snapshot_id=3051729675574597004,
tag_name="test123")
+
+ new_metadata = update.table_metadata
Review Comment:
> I tried committing the transaction, but that raises this error (below)
Thanks for trying this! I overlooked that this is in unit test and we do not
have a production catalog that supports `_commit_table`. How about we adding
some integration tests? Those tests are under `tests/integration` folder and
can be triggered via
```
make test-integration
```
In integration test environment, we have configured a RestCatalog and a
HiveCatalog that can commit to a real iceberg table. The following will be a
good example:
https://github.com/apache/iceberg-python/blob/cf3bf8a977f80f986237bc62293666de327871b3/tests/integration/test_partition_evolution.py#L199-L207
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
