chinmay-bhat commented on PR #728: URL: https://github.com/apache/iceberg-python/pull/728#issuecomment-2106543381
@syun64 thank you for the review! In regards to testing, I see that the tests are all performed on the classes that are called by the APIs. None of the tests are directly on the APIs. For example, there's already a test `test_update_metadata_set_snapshot_ref` that calls `SetSnapshotRefUpdate` which is also the class that we would call to test `set_ref_snapshot`. Do I still need to create unit tests for `set_ref_snapshot` API in `Transaction` and `Table`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
