geruh commented on code in PR #10199:
URL: https://github.com/apache/iceberg/pull/10199#discussion_r1585580662


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -322,6 +322,7 @@ void persistGlueTable(
                       .name(tableName)
                       .tableType(GLUE_EXTERNAL_TABLE_TYPE)
                       .parameters(parameters)
+                      .description(glueTable.description())

Review Comment:
   Looks good @aajisaka this is great!
   
   Recently we added support for setting the glue description via the `comment` 
table property in #9530. What are your thoughts on leveraging this table 
property to set the Glue description. This would allow a user to perform an 
ALTER statement to update the glue description as well. 
   
   ```
   ALTER TABLE prod.db.sample SET TBLPROPERTIES (
       'comment' = 'A table description.'
   )
   ```
   
   cc: @amogh-jahagirdar 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to