RussellSpitzer commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1543265194
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -237,10 +243,36 @@ public Snapshot apply() {
OutputFile manifestList = manifestListPath();
+ EncryptionManager encryptionManager = ops.encryption();
+ EncryptedOutputFile encryptedManifestList =
encryptionManager.encrypt(manifestList);
+
+ long manifestListSize;
+ String manifestListKeyMetadata = null;
+ if (encryptedManifestList.keyMetadata() != null
+ && encryptedManifestList.keyMetadata().buffer() != null) {
+ Preconditions.checkArgument(
+ encryptionManager instanceof StandardEncryptionManager,
+ "Encryption manager for encrypted manifest list files can currently
only be an instance of "
Review Comment:
similar comment as above. "Cannot X because Y"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
