RussellSpitzer commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1543221066
##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -62,15 +73,41 @@ class BaseSnapshot implements Snapshot {
Map<String, String> summary,
Integer schemaId,
String manifestList) {
+ this(
+ sequenceNumber,
+ snapshotId,
+ parentId,
+ timestampMillis,
+ operation,
+ summary,
+ schemaId,
+ manifestList,
+ -1L,
+ null);
+ }
+
+ BaseSnapshot(
+ long sequenceNumber,
+ long snapshotId,
+ Long parentId,
+ long timestampMillis,
+ String operation,
+ Map<String, String> summary,
+ Integer schemaId,
+ String manifestListLocation,
+ long manifestListSize,
+ String manifestListKeyMetadata) {
this.sequenceNumber = sequenceNumber;
this.snapshotId = snapshotId;
this.parentId = parentId;
this.timestampMillis = timestampMillis;
this.operation = operation;
this.summary = summary;
this.schemaId = schemaId;
- this.manifestListLocation = manifestList;
+ this.manifestListLocation = manifestListLocation;
+ this.manifestListSize = manifestListSize;
this.v1ManifestLocations = null;
+ this.manifestListKeyMetadata = manifestListKeyMetadata;
Review Comment:
nit: keep with the other manifestList assignments (move up 1 line)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
