ggershinsky commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1538620497
##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -162,6 +162,15 @@ default Iterable<DeleteFile> removedDeleteFiles(FileIO io)
{
*/
String manifestListLocation();
+ /**
+ * Return the size of this snapshot's manifest list. For encrypted tables, a
verified plaintext
Review Comment:
fix comment
##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -143,7 +192,39 @@ private void cacheManifests(FileIO fileIO) {
if (allManifests == null) {
// if manifests isn't set, then the snapshotFile is set and should be
read to get the list
- this.allManifests =
ManifestLists.read(fileIO.newInputFile(manifestListLocation));
+ // TODO GG
Review Comment:
rm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
