RussellSpitzer commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1543238877


##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -143,7 +192,38 @@ private void cacheManifests(FileIO fileIO) {
 
     if (allManifests == null) {
       // if manifests isn't set, then the snapshotFile is set and should be 
read to get the list
-      this.allManifests = 
ManifestLists.read(fileIO.newInputFile(manifestListLocation));
+      InputFile manifestListFile = fileIO.newInputFile(manifestListLocation);
+      if (manifestListKeyMetadata != null) { // encrypted manifest list file
+        Preconditions.checkArgument(
+            fileIO instanceof EncryptingFileIO,
+            "No encryption in FileIO class " + fileIO.getClass());
+        EncryptingFileIO encryptingFileIO = (EncryptingFileIO) fileIO;
+        Preconditions.checkArgument(
+            encryptingFileIO.encryptionManager() instanceof 
StandardEncryptionManager,
+            "Encryption manager for encrypted manifest list files can 
currently only be an instance of "

Review Comment:
   Cannot decrypt manifest list (%s) because the encryption manager does not 
implement StandardEncryptionManager



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to