szehon-ho commented on code in PR #10020:
URL: https://github.com/apache/iceberg/pull/10020#discussion_r1540214185
##########
core/src/main/java/org/apache/iceberg/PositionDeletesTable.java:
##########
@@ -196,15 +265,14 @@ protected List<String> scanColumns() {
*/
public BatchScan baseTableFilter(Expression expr) {
return new PositionDeletesBatchScan(
- table(), schema(), context(), Expressions.and(baseTableFilter,
expr));
+ table(), schema(), context(), Expressions.and(baseTableFilter,
expr), fieldMap);
}
@Override
protected CloseableIterable<ScanTask> doPlanFiles() {
String schemaString = SchemaParser.toJson(tableSchema());
-
- // prepare transformed partition specs and caches
- Map<Integer, PartitionSpec> transformedSpecs =
transformSpecs(tableSchema(), table().specs());
+ Map<Integer, PartitionSpec> transformedSpecs =
Review Comment:
We use the transformed spec to evaluate the filters, so we need to bind
against the new (reassigned) field ids, hence passing the field id map here so
the transformed specs have them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
