szehon-ho commented on code in PR #10020:
URL: https://github.com/apache/iceberg/pull/10020#discussion_r1540229802
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java:
##########
@@ -458,6 +460,7 @@ public int totalGroupCount() {
}
private StructLike coercePartition(PositionDeletesScanTask task, StructType
partitionType) {
- return PartitionUtil.coercePartition(partitionType, task.spec(),
task.partition());
+ Types.StructType dedupType =
PositionDeletesTable.partitionType(table.schema(), partitionType);
Review Comment:
This was using the original partition type to coerce partition (for grouping
during the rewrite), but we actually need the final partition type (with
reassigned field ids). This is because PositionDeletesScanTask now has
partition data that matches the reassigned field ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
