bitsondatadev commented on code in PR #257:
URL: https://github.com/apache/iceberg-rust/pull/257#discussion_r1525193851
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -83,7 +83,7 @@ pub trait Catalog: Debug + Sync + Send {
async fn drop_table(&self, table: &TableIdent) -> Result<()>;
/// Check if a table exists in the catalog.
- async fn stat_table(&self, table: &TableIdent) -> Result<bool>;
+ async fn table_exists(&self, table: &TableIdent) -> Result<bool>;
Review Comment:
Agreed, also reading back to the previous comments, `<verb>_<noun>` is
always a tricky one to keep consistent when you switch from a command like
`get_table` or `put_metadata`, etc.. to asking a question about the state as it
changes the structure in English. So in most practices, anything that is
verifying the state and returning a boolean gets special treatment.
More importantly, let's just do what we've done in other APIs to the best of
our ability. I optimize on someone being able to guess the method name without
referencing the docs based on their knowledge of python or java apis.
That said, this gets tricky when you add in language specific practices and
nuances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
