Fokko commented on code in PR #257:
URL: https://github.com/apache/iceberg-rust/pull/257#discussion_r1524690541
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -83,7 +83,7 @@ pub trait Catalog: Debug + Sync + Send {
async fn drop_table(&self, table: &TableIdent) -> Result<()>;
/// Check if a table exists in the catalog.
- async fn stat_table(&self, table: &TableIdent) -> Result<bool>;
+ async fn table_exists(&self, table: &TableIdent) -> Result<bool>;
Review Comment:
I'm not a native English speaker either, so bear with me here.
`is_table_exists` sounds odd to me that's why I suggested `table_exists`. If it
was on the table itself, I can see that you have something like:
`Catalog.load('some.entity').is_view`, `Catalog.load('some.entity').is_table`.
But since this method is on the Catalog, I think it makes more sense to have
`table_exists`, similar to `create_table`.
Calling in @bitsondatadev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
