Xuanwo commented on code in PR #257:
URL: https://github.com/apache/iceberg-rust/pull/257#discussion_r1522945260
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -83,7 +83,7 @@ pub trait Catalog: Debug + Sync + Send {
async fn drop_table(&self, table: &TableIdent) -> Result<()>;
/// Check if a table exists in the catalog.
- async fn stat_table(&self, table: &TableIdent) -> Result<bool>;
+ async fn table_exists(&self, table: &TableIdent) -> Result<bool>;
Review Comment:
> But it's kind of weird to add `is_` for `exists` method, see
[Path::exists](https://doc.rust-lang.org/std/path/struct.Path.html#method.exists).
I believe this is because `exists` is an API method for `Path` itself. Our
case here is more similar to
[`is_file`](https://doc.rust-lang.org/std/path/struct.Path.html#method.is_file),
[`is_dir`](https://doc.rust-lang.org/std/path/struct.Path.html#method.is_dir),
and
[`is_absolute`](https://doc.rust-lang.org/std/path/struct.Path.html#method.is_absolute).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
