bitsondatadev commented on code in PR #257:
URL: https://github.com/apache/iceberg-rust/pull/257#discussion_r1525126580
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -83,7 +83,7 @@ pub trait Catalog: Debug + Sync + Send {
async fn drop_table(&self, table: &TableIdent) -> Result<()>;
/// Check if a table exists in the catalog.
- async fn stat_table(&self, table: &TableIdent) -> Result<bool>;
+ async fn table_exists(&self, table: &TableIdent) -> Result<bool>;
Review Comment:
My opinion only: Provided you can understand the basic intention, I believe
making it sound like proper English isn't a concern. That's what documentation
is for. To me, convention is the most important, so that if you have no
documentation, ideally it's like every other function call that verifies if a
table exists?
What do we call it in PyIceberg? What does Delta call it? Don't follow Hudi
whatever they do, especially if it's different.
If there's no consensus `table_exists` is just fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
