Fokko commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1524685842
##########
pyiceberg/table/__init__.py:
##########
@@ -382,7 +383,54 @@ def commit_transaction(self) -> Table:
return self._table
+class CreateTableTransaction(Transaction):
+ @staticmethod
+ def create_changes(table_metadata: TableMetadata) -> Tuple[TableUpdate,
...]:
Review Comment:
I think we can also accumulate the changes in `_updates` of the
`Transaction` itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
