syun64 commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1513259769


##########
pyiceberg/table/__init__.py:
##########
@@ -753,6 +807,143 @@ def update_table_metadata(base_metadata: TableMetadata, 
updates: Tuple[TableUpda
     return new_metadata.model_copy(deep=True)
 
 
+class InitialTableMetadataConstructor:

Review Comment:
   According to the Rest Catalog Open API spec, only the **format-version** and 
the **table-uuid** are the only required attributes of the entire Spec. What 
are your thoughts on updating the TableMetadataCommonFields Fields to align 
with the Rest Catalog Open API Spec? This will also allow us to create a Base 
TableMetadata, and use the existing **_apply_table_update** functions instead 
of having to write a separate constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to