HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1513709599
##########
pyiceberg/table/__init__.py:
##########
@@ -753,6 +807,143 @@ def update_table_metadata(base_metadata: TableMetadata,
updates: Tuple[TableUpda
return new_metadata.model_copy(deep=True)
+class InitialTableMetadataConstructor:
Review Comment:
> What are your thoughts on updating the TableMetadataCommonFields Fields to
align with the Rest Catalog Open API Spec?
I am also in favor of this approach. I tried to construct an EMPTY_METADATA
but failed because of those "before" validators. For example,
[construct_partition_specs](https://github.com/apache/iceberg-python/blob/main/pyiceberg/table/metadata.py#L328-L345)
automatically insert an unpartitioned spec to the metadata if there is no
existing partition spec. Let me investigate how to refactor the common fields
and these validators to allow a Base TableMetadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
