Fokko commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1522750042


##########
pyiceberg/table/__init__.py:
##########
@@ -2697,6 +2810,9 @@ def __init__(self, transaction: Transaction, io: FileIO) 
-> None:
     def fast_append(self) -> FastAppendFiles:
         return FastAppendFiles(operation=Operation.APPEND, 
transaction=self._transaction, io=self._io)
 
+    def merge_append(self) -> MergeAppendFiles:
+        return MergeAppendFiles(operation=Operation.APPEND, 
transaction=self._transaction, io=self._io)

Review Comment:
   I see that the signature is the same as the fast-append. My intention was to 
enable folks to use either merge or fast-append through the API, rather than 
having to set table properties.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to