syun64 commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1536160297
##########
pyiceberg/table/__init__.py:
##########
@@ -1091,7 +1111,7 @@ def append(self, df: pa.Table) -> None:
_check_schema(self.schema(), other_schema=df.schema)
with self.transaction() as txn:
- with txn.update_snapshot().fast_append() as update_snapshot:
+ with txn.update_snapshot().merge_append() as update_snapshot:
Review Comment:
Could we update the [new add_files
method](https://github.com/apache/iceberg-python/blob/6989b92c2d449beb9fe4817c64f619ea5bfc81dc/pyiceberg/table/__init__.py#L1184)
to also use `merge_append`?
That seems to be the default choice of snapshot producer in
[Java](https://github.com/apache/iceberg/blob/1.4.x/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java#L512)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
