syun64 commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1539066736
##########
pyiceberg/table/__init__.py:
##########
@@ -1091,7 +1111,7 @@ def append(self, df: pa.Table) -> None:
_check_schema(self.schema(), other_schema=df.schema)
with self.transaction() as txn:
- with txn.update_snapshot().fast_append() as update_snapshot:
+ with txn.update_snapshot().merge_append() as update_snapshot:
Review Comment:
That's a good argument @Fokko . Especially in a world where we are
potentially moving the work of doing table scans into the Rest Catalog,
compacting manifests on write isn't important for this function that already
looks to prioritize commit speed over anything else.
I think it makes sense to leave the function to use _fast_append_ and let
the users rely on other means of optimizing their table scans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
