nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1519276012
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -62,6 +81,57 @@ interface HiveOperationsBase {
String table();
+ String catalogName();
+
+ String entityType();
+
+ BaseMetastoreOperations.CommitStatus
validateNewLocationAndReturnCommitStatus(
+ BaseMetadata metadata, String newMetadataLocation);
+
+ default Table loadHmsTable() throws TException, InterruptedException {
+ try {
+ return metaClients().run(client -> client.getTable(database(), table()));
+ } catch (NoSuchObjectException nte) {
+ LOG.trace("{} not found {}", entityType(), fullName(), nte);
+ return null;
+ }
+ }
+
+ void setHmsParameters(
+ BaseMetadata metadata,
Review Comment:
I understand that for tables you have to configure more things and my
comment is not about tables, but for views there's no reason to introduce this
abstraction just to be able to pass the schema of the view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
