szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520440313
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -181,4 +264,220 @@ default Table newHmsTable(String hmsTableOwner) {
return newTable;
}
+
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
+ default void commitWithLocking(
+ Configuration conf,
+ BaseMetadata base,
+ BaseMetadata metadata,
+ String baseMetadataLocation,
+ String newMetadataLocation,
+ FileIO io) {
+ boolean newTable = base == null;
+ boolean hiveEngineEnabled = hiveEngineEnabled(conf, metadata);
+ BaseMetastoreTableOperations.CommitStatus commitStatus =
+ BaseMetastoreTableOperations.CommitStatus.FAILURE;
+ boolean updateHiveTable = false;
+ HiveLock lock = lockObject(metadata, conf, catalogName());
+ try {
+ lock.lock();
+ Table tbl = loadHmsTable();
+
+ if (tbl != null) {
+ String tableType = tbl.getTableType();
+ if (!tableType.equalsIgnoreCase(tableType().name())) {
Review Comment:
Not sure I follow, what happens when we dont have this? Is it just the
error message is wrong? I feel we can mostly re-use the existing exception
(maybe can add the type).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
