szehon-ho commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516670655
########## core/src/main/java/org/apache/iceberg/BaseMetadata.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.Serializable; +import java.util.Map; +import javax.annotation.Nullable; +import org.apache.iceberg.util.PropertyUtil; + +/** A base class for {@link TableMetadata} and {@link org.apache.iceberg.view.ViewMetadata} */ +public interface BaseMetadata extends Serializable { Review Comment: @nastra we had discussed this a bit, with @pvary as well , you can take a look at the original pr https://github.com/apache/iceberg/pull/8907/files without the common metadata. The main motivation is that HiveCatalog/ HiveTableOperations code is a bit hard to get right in terms of failure handling/locking, and cloning it is not that great. The common metadata is the minimum to allow that code to be shared. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
