nk1506 commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1520204263
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -62,6 +81,57 @@ interface HiveOperationsBase {
String table();
+ String catalogName();
+
+ String entityType();
+
+ BaseMetastoreOperations.CommitStatus
validateNewLocationAndReturnCommitStatus(
+ BaseMetadata metadata, String newMetadataLocation);
+
+ default Table loadHmsTable() throws TException, InterruptedException {
+ try {
+ return metaClients().run(client -> client.getTable(database(), table()));
+ } catch (NoSuchObjectException nte) {
+ LOG.trace("{} not found {}", entityType(), fullName(), nte);
+ return null;
+ }
+ }
+
+ void setHmsParameters(
+ BaseMetadata metadata,
Review Comment:
We do have
[setCommonHmsParameters](https://github.com/apache/iceberg/pull/9852/files#diff-5ecfc223b311b523a12be7482b6235318fdd7535c371f899daf7e09eacddad77R123)
which is being used by both table and view. Infact the same can be used
directly by
[view](https://github.com/apache/iceberg/pull/9852/files#diff-db46657b84d66e084e15f31b8dab21577efb2ae7102863f94c6c9477782de676R167).
But we have to add a conditional statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
