nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516214487


##########
core/src/main/java/org/apache/iceberg/MetadataTableUtils.java:
##########
@@ -100,9 +100,8 @@ public static Table createMetadataTableInstance(
       TableIdentifier baseTableIdentifier,
       TableIdentifier metadataTableIdentifier,
       MetadataTableType type) {
-    String baseTableName = BaseMetastoreCatalog.fullTableName(catalogName, 
baseTableIdentifier);
-    String metadataTableName =
-        BaseMetastoreCatalog.fullTableName(catalogName, 
metadataTableIdentifier);
+    String baseTableName = CatalogUtil.fullTableName(catalogName, 
baseTableIdentifier);

Review Comment:
   this doesn't have to change because we need to keep 
`BaseMetastoreCatalog.fullTableName` so that we don't break the API



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to