nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516198321
##########
.palantir/revapi.yml:
##########
@@ -977,6 +980,10 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.SerializableMap<K,
V>.serialVersionUID"
justification: "Serialization is not be used"
+ - code: "java.method.removed"
+ old: "method java.lang.String
org.apache.iceberg.BaseMetastoreCatalog::fullTableName(java.lang.String,\
Review Comment:
we shouldn't be breaking existing APIs. I understand that one might want to
move the method to a different place for better usage across other places, but
we need to do this in a way that doesn't break existing APIs.
This could be achieved e.g. by still keeping
`BaseMetastoreCatalog::fullTableName` which would internally call
`CatalogUtil.fullTableName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
