nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516254101
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -269,6 +284,160 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
}
}
+ @Override
+ public boolean dropView(TableIdentifier identifier) {
+ if (!isValidIdentifier(identifier)) {
+ return false;
+ }
+
+ try {
+ String database = identifier.namespace().level(0);
+ String viewName = identifier.name();
+ Table table = clients.run(client -> client.getTable(database, viewName));
+ HiveViewOperations.validateTableIsIcebergView(
+ table, CatalogUtil.fullTableName(name, identifier));
+ clients.run(
+ client -> {
+ client.dropTable(database, viewName);
+ return null;
+ });
+ LOG.info("Dropped View: {}", identifier);
+ return true;
+
+ } catch (NoSuchViewException | NoSuchObjectException e) {
+ LOG.info("Skipping drop, View does not exist: {}", identifier, e);
+ return false;
+ } catch (TException e) {
+ throw new RuntimeException("Failed to drop " + identifier, e);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException("Interrupted in call to dropView", e);
+ }
+ }
+
+ @Override
+ public List<TableIdentifier> listViews(Namespace namespace) {
+ Preconditions.checkArgument(
+ isValidateNamespace(namespace), "Missing database in namespace: %s",
namespace);
+
+ try {
+ return listTablesByType(
+ namespace, TableType.VIRTUAL_VIEW,
BaseMetastoreTableOperations.ICEBERG_VIEW_TYPE_VALUE);
+ } catch (UnknownDBException e) {
+ throw new NoSuchNamespaceException("Namespace does not exist: %s",
namespace);
+
+ } catch (TException e) {
+ throw new RuntimeException("Failed to list all views under namespace " +
namespace, e);
+
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException("Interrupted in call to listViews", e);
+ }
+ }
+
+ private List<TableIdentifier> listTablesByType(
+ Namespace namespace, TableType tableType, String tableTypeProp)
+ throws TException, InterruptedException {
+ String database = namespace.level(0);
+ List<String> tableNames = clients.run(client -> client.getTables(database,
"*", tableType));
+
+ // Retrieving the Table objects from HMS in batches to avoid OOM
+ List<TableIdentifier> filteredTableIdentifiers = Lists.newArrayList();
+ Iterable<List<String>> tableNameSets = Iterables.partition(tableNames,
100);
+
+ for (List<String> tableNameSet : tableNameSets) {
+ filteredTableIdentifiers.addAll(filterIcebergTables(tableNameSet,
namespace, tableTypeProp));
+ }
+
+ return filteredTableIdentifiers;
+ }
+
+ private List<TableIdentifier> filterIcebergTables(
+ List<String> tableNames, Namespace namespace, String tableTypeProp)
+ throws TException, InterruptedException {
+ List<Table> tableObjects =
+ clients.run(client -> client.getTableObjectsByName(namespace.level(0),
tableNames));
+ return tableObjects.stream()
+ .filter(
+ table ->
+ table.getParameters() != null
+ && tableTypeProp.equalsIgnoreCase(
+
table.getParameters().get(BaseMetastoreTableOperations.TABLE_TYPE_PROP)))
+ .map(table -> TableIdentifier.of(namespace, table.getTableName()))
+ .collect(Collectors.toList());
+ }
+
+ @Override
+ @SuppressWarnings("FormatStringAnnotation")
+ public void renameView(TableIdentifier from, TableIdentifier originalTo) {
+
+ if (!isValidIdentifier(from)) {
+ throw new NoSuchViewException("Invalid identifier: %s", from);
+ }
+
+ if (!namespaceExists(originalTo.namespace())) {
Review Comment:
yes, this is correct to have this here and there are tests that verify this
behavior. This also needs to be fixed for tables (probably in a separate PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
