nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1516213304
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -473,4 +487,27 @@ public static MetricsReporter
loadMetricsReporter(Map<String, String> properties
return reporter;
}
+
+ public static String fullTableName(String catalogName, TableIdentifier
identifier) {
Review Comment:
given that this method is being publicly exposed, I think there should be
tests that verify different inputs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
