nastra commented on code in PR #9877:
URL: https://github.com/apache/iceberg/pull/9877#discussion_r1515710861
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##########
@@ -132,6 +134,31 @@ public void testSettingProperties() {
.hasMessage("Namespace does not exist: unknown");
}
+ @Test
+ public void testEmptyNamespace() {
+ Assertions.assertThatThrownBy(
+ () -> catalog.createNamespace(Namespace.empty(),
Collections.emptyMap()))
+ .isInstanceOf(NoSuchNamespaceException.class)
+ .hasMessage("Invalid namespace: ");
+
Assertions.assertThat(catalog.namespaceExists(Namespace.empty())).isFalse();
+ Assertions.assertThatThrownBy(() ->
catalog.loadNamespaceMetadata(Namespace.empty()))
+ .isInstanceOf(NoSuchNamespaceException.class)
+ .hasMessage("Invalid namespace: ");
+ Assertions.assertThatThrownBy(
Review Comment:
maybe just add a new line after each assertion to make it slightly easier to
read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
