ajantha-bhat commented on code in PR #9877:
URL: https://github.com/apache/iceberg/pull/9877#discussion_r1514489991
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -308,6 +308,10 @@ public List<Namespace> listNamespaces(Namespace namespace)
throws NoSuchNamespac
}
public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyException {
+ if (namespace.isEmpty()) {
+ // As creating empty namespaces is not supported
+ throw new NoSuchNamespaceException("Namespace does not exist: %s",
namespace);
Review Comment:
Many existing places we don't wrap it. Like `loadNamespaceMetadata`,
`updateProperties`.
Also checked that other catalogs doesn't wrap it too.
So, some common test may fail if I wrap it.
We can analyze in the follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
