nastra commented on code in PR #9877:
URL: https://github.com/apache/iceberg/pull/9877#discussion_r1514502547
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -380,6 +389,10 @@ public boolean removeProperties(Namespace namespace,
Set<String> properties) {
}
private boolean updateProperties(Namespace namespace, Consumer<Map<String,
String>> action) {
+ if (namespace.isEmpty()) {
+ // As creating empty namespaces is not supported
+ throw new IllegalArgumentException("Empty namespaces not supported");
Review Comment:
this should be singular instead of plural. The same should probably be
updated for the error msg that is thrown when an empty namespace is created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
