nastra commented on code in PR #9877:
URL: https://github.com/apache/iceberg/pull/9877#discussion_r1515710123
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -353,8 +352,17 @@ public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyExcept
return false;
}
+ private static void checkNamespaceIsValid(Namespace namespace) {
+ if (namespace.isEmpty()) {
+ // As creating empty namespace is not supported
Review Comment:
I would just remove this comment as it's confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
