jackye1995 commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1513085638
##########
api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java:
##########
@@ -44,6 +47,39 @@ public interface RewriteManifests
*/
RewriteManifests rewriteIf(Predicate<ManifestFile> predicate);
+ /**
+ * Rewrite manifests in a given order, based on partition field names
+ *
+ * <p>Supply an optional set of partition field names to sort the rewritten
manifests by. Expects
+ * exact transformed column names used for partitioning; not the raw
columnnames that partitions
+ * are derived from. E.G. supply 'data_bucket' and not 'data' for a
bucket(N, data) partition
+ * definition
+ *
+ * <p>If not set, manifests will be rewritten in the order of the transforms
in the table's
+ * current partition spec.
+ *
+ * @param partitionFieldSortOrder a list of partition field names
+ * @return this for method chaining
+ */
+ default RewriteManifests sort(List<String> partitionFieldSortOrder) {
Review Comment:
One thing to double click here with everyone. I think we originally landed
the API name as `sort` on devlist, but the implementation is using
`partitionByRange`. In that case, I feel `clusterBy` is a more suitable name
for this API (and also the other one below). What do we think? @zachdisc
@RussellSpitzer @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
