nk1506 commented on code in PR #9862:
URL: https://github.com/apache/iceberg/pull/9862#discussion_r1510995578
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -185,16 +184,22 @@ public TableTestBase(int formatVersion) {
this.V2Assert = new TableAssertions(2, formatVersion);
}
- @Before
+ public TableTestBase() {
Review Comment:
@nastra what will you recommend for class like
[TestAppenderFactory](https://github.com/apache/iceberg/blob/bcbcbb263ea7e13ab22d0feb918e207c7e42dbbd/data/src/test/java/org/apache/iceberg/io/TestAppenderFactory.java#L65)
which has different set of parameters.
```
@Parameterized.Parameters(name = "FileFormat={0}, Partitioned={1}")
public static Object[] parameters() {
return new Object[][] {
new Object[] {"avro", false},
new Object[] {"avro", true},
new Object[] {"orc", false},
new Object[] {"orc", true},
new Object[] {"parquet", false},
new Object[] {"parquet", true}
};
}
```
If this class will extend `TestBase` instead of `TableTestBase` there will
be a conflict on parameters definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
