nk1506 commented on code in PR #9862:
URL: https://github.com/apache/iceberg/pull/9862#discussion_r1510799947
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -185,16 +184,22 @@ public TableTestBase(int formatVersion) {
this.V2Assert = new TableAssertions(2, formatVersion);
}
- @Before
+ public TableTestBase() {
Review Comment:
As per my understanding, We won't be able to get rid of `TableTestBase` .
`TestBase` has it's own implementation of `ParameterizedTestExtension`. Many of
the subclass of `TableTestBase` has different flavour of
`ParameterizedTestExtension`. I will plan to use `TestBase` wherever it fits. I
will also add a javadoc for both class which one should be used when. Meanwhile
, Could you please take a highlevel look for the Temp directory or file
initialization? Also I will remove all the classes on which @tomtongue was
working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
