nastra commented on code in PR #9862:
URL: https://github.com/apache/iceberg/pull/9862#discussion_r1510948799
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -185,16 +184,22 @@ public TableTestBase(int formatVersion) {
this.V2Assert = new TableAssertions(2, formatVersion);
}
- @Before
+ public TableTestBase() {
Review Comment:
@nk1506 `TestBase` is what needs to be used and it uses the
`ParameterizedTestExtension` that is compatible with JUnit5. The
`ParameterizedTestExtension` used by `TableTestBase` and its subclasses only
works with JUnit4. If you look for example at #9790, you'll see how
parameterized JUnit4 tests need to be migrated to parameterized JUnit5 tests.
That being said, every subclass of `TableTestBase` that is migrated to
JUnit5 needs to now extend `TestBase` and use
`org.apache.iceberg.ParameterizedTestExtension`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
