nastra commented on code in PR #9862:
URL: https://github.com/apache/iceberg/pull/9862#discussion_r1510699475
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -185,16 +184,22 @@ public TableTestBase(int formatVersion) {
this.V2Assert = new TableAssertions(2, formatVersion);
}
- @Before
+ public TableTestBase() {
Review Comment:
because there are so many subclasses of `TableTestBase`, we decided to
introduce `TestBase`, which is a JUnit5 version of `TableTestBase`. That way,
we don't have to adjust all subclasses in one go and can therefore split up the
required changes into smaller chunks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
