zachdisc commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1494869944
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -208,7 +243,15 @@ private RewriteManifests.Result
rewriteManifests(ManifestContent content) {
if (spec.isUnpartitioned()) {
newManifests = writeUnpartitionedManifests(content, manifestEntryDF,
targetNumManifests);
} else {
- newManifests = writePartitionedManifests(content, manifestEntryDF,
targetNumManifests);
+ if (partitionSortColumns != null) {
Review Comment:
That makes sense. I was probably just hesitant to touch the main working
path with a custom extractor, but I can make that switch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
