nastra commented on code in PR #9670:
URL: https://github.com/apache/iceberg/pull/9670#discussion_r1494620947
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -1052,9 +1039,10 @@ public synchronized void
testDeleteWithSerializableIsolation() throws Interrupte
executorService.submit(
() -> {
for (int numOperations = 0; numOperations < Integer.MAX_VALUE;
numOperations++) {
- while (barrier.get() < numOperations * 2) {
- sleep(10);
- }
+ int currentNumOperations = numOperations;
+ Awaitility.await()
+ .pollInterval(Duration.ofMillis(10))
Review Comment:
I think all of these should have `.atMost(5, TimeUnit.SECONDS)` because we
don't want to wait indefinitely for the condition to happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
