nastra commented on code in PR #9670:
URL: https://github.com/apache/iceberg/pull/9670#discussion_r1494119575


##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -1181,7 +1170,7 @@ public synchronized void testDeleteWithSnapshotIsolation()
                   }
 
                   appendFiles.commit();
-                  sleep(10);
+                  
Awaitility.await().pollInterval(Duration.ofMillis(10)).until(() -> true);

Review Comment:
   I don't think this makes a lot of sense to replace this sleep with 
Awaitility. I wonder whether this sleep here is even necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to