tomtongue commented on code in PR #9670:
URL: https://github.com/apache/iceberg/pull/9670#discussion_r1494484011


##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -1181,7 +1170,7 @@ public synchronized void testDeleteWithSnapshotIsolation()
                   }
 
                   appendFiles.commit();
-                  sleep(10);
+                  
Awaitility.await().pollInterval(Duration.ofMillis(10)).until(() -> true);

Review Comment:
   Got the reason of the test failure. The reason seems to be the conflicts of 
the appended file names. When I tested using a randomized name for each 
appendFile, all the tests succeeded (the previous version sets the randomized 
names). And in this case, as you said, `sleep` is no longer needed. Let me fix 
the file name configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to