tomtongue commented on code in PR #9670:
URL: https://github.com/apache/iceberg/pull/9670#discussion_r1494143891


##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -1181,7 +1170,7 @@ public synchronized void testDeleteWithSnapshotIsolation()
                   }
 
                   appendFiles.commit();
-                  sleep(10);
+                  
Awaitility.await().pollInterval(Duration.ofMillis(10)).until(() -> true);

Review Comment:
   Let me revert this to `sleep`. Currently the snapshotIsolation tests for 
`TestDelete`, `TestMerge` and `TestUpdate` are still flaky. From my 
investigation, the test failure seems to be related to the `appendFiles`. 
   For now, I observed:
   * the bigger value like`sleep(1000)`, the less tests fail.
   * the less `numAppends` like `numAppends < 1`, the less tests fail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to