jbonofre commented on PR #9487: URL: https://github.com/apache/iceberg/pull/9487#issuecomment-1948053941
@nastra @ajantha-bhat @danielcweeks @rdblue I updated the PR by introducing `SchemaVersion`, but I keep the same `jdbc.add-view-support` property for users. Some notes: 1. I didn't rename all statements to use `V1_`, only on the statements where we have a difference between `V0` and `V1`. 2. As we only have `V0` and `V1` for now, I still use `if` (not `switch`). We will eventually change later when introducing a new schema version. 3. After 1.5.0 release, I plan to refactore the `JdbcCatalog` using `JdbcAdapter` (similar to what I did in Apache ActiveMQ for the JDBC store). It will allow to support different backends and having statements specific to backend when needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
