nastra commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484373833
########## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ########## @@ -158,6 +161,92 @@ public void testInitialize() { jdbcCatalog.initialize("test_jdbc_catalog", properties); } + @Test + public void testSchemaUpdate() throws Exception { Review Comment: minor: `testSchemaUpdate` isn't really telling much about what's exactly being tested, that's why I suggested to name this `schemaIsMigratedToAddViewSupport` so that it's explicit that we care about view support being added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org